-
Notifications
You must be signed in to change notification settings - Fork 4
Fixing DEFAULT_ATTR_KEYS usage
#234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixing DEFAULT_ATTR_KEYS usage
#234
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 88.50% 88.48% -0.02%
==========================================
Files 55 55
Lines 3959 3953 -6
Branches 696 696
==========================================
- Hits 3504 3498 -6
Misses 273 273
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! This makes sense a lot!
|
|
uhm... , ok, if we bind everything to the graph, then every default |
|
Right, in that sense, the current implementation looks better for me! |
|
We also need to implement the attr name conversion in functions that read other file formats such as GEFF. |
|
All looks good to me, thanks @JoOkuma! (Btw happy new year!) |
node_id,source_id, etc.. usage inSQLGraphnode_idandsource_id, etc.